hotfix/BA-3024-fe-markdown-improvement#335
hotfix/BA-3024-fe-markdown-improvement#335davidbermudez-tsl wants to merge 1 commit intoBA-2167-FE-markdown-editorfrom
Conversation
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
edbf695 to
2d29acb
Compare
|
| <Markdown | ||
| components={{ | ||
| // eslint-disable-next-line react/no-unstable-nested-components | ||
| p: ({ children, ...props }) => ( |
There was a problem hiding this comment.
could we extract this component and place it at packages/design-system/components/web/inputs?
we could even consider creating a packages/design-system/components/web/markdowns folder and move it all there
lokmanliton
left a comment
There was a problem hiding this comment.
- Numbered list is not working, after sending the message I don't see number and indentation,
- For bullet point - I see it is working at message box, not in text-box,
- After sending message, message text-box doesn't become empty, texts are still there,
- bullet point goes inside the coding block,



Original Story:
Acceptance Criteria
Context
Whenever we send a message that uses a markdown format, it is not displayed as intended.
Business Rules
Markdown elements behave as expected in standard messaging and documentation applications.
Formatting remains consistent across different devices and screen sizes.
No display issues such as incorrect colors, spacing, or layout misalignment.
Inline code should:
Display in a standard monospaced font.
Have a subtle background color (not yellow or unintended colors).
Ordered lists and unordered lists should:
Display correct numbering or bullet points.
Be properly indented.
Maintain consistent spacing between list items.
Quote blocks should:
Expand properly within the chat bubble.
Be visually distinct and not squeezed.
Code blocks should
Render within a properly formatted container.
Avoid text overlap or breaking issues.
Markdown input box should:
Follow the correct borders and layout of the message input box.
Markdown elements behave as expected in standard messaging and documentation applications.
Formatting remains consistent across different devices and screen sizes.
No display issues such as incorrect colors, spacing, or layout misalignment.
Current behavior
Expected behavior
Code Snippet
Notes
Try with the new editor: https://github.com/mdx-editor/editor
If it doesn't work we can try to use the preview one: https://github.com/uiwjs/react-markdown-preview
To start we need to do a rebase
It's important to check the message preview below a group or the person name
Approvd
https://app.approvd.io/silverlogic/BA/stories/43064