Feature/ba 2982 rn nested comment threads#322
Feature/ba 2982 rn nested comment threads#322lbjunq wants to merge 19 commits intoepic/BA-2239-react-native-commentsfrom
Conversation
…rlogic/baseapp-frontend into feature/BA-2940-rn-edit-comment
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Failure to add the new IP will result in interrupted reviews. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This PR is not ready for review. Wait for merge on the Reply to Comments before reviewing this. |
|
It is also dependant on this BE PR. Wait for merge or run locally |
|
@lbjunq please resolve conflicts and rebase with the epic so we can review |
|
| alignItems: 'center', | ||
| gap: 4, | ||
| }, | ||
| hideRepliesButtonText: { |
There was a problem hiding this comment.
This style seems to be the same as the variant "buttonSmall". Could you change to use the variable instead of this?
| </View> | ||
| </Pressable> | ||
| {isRepliesExpanded && !isLoadingReplies && renderCommentsReplies()} | ||
| {isRepliesExpanded && !isLoadingReplies && canReply && renderCommentsReplies()} |
There was a problem hiding this comment.
Since you have a function to renderCommentsReplies, could you move this logic to the function to make the code cleaner?
| threadDepth = 0, | ||
| maxThreadDepth = 5, | ||
| RepliesList: RepliesListProp, | ||
| RepliesListProps, |
There was a problem hiding this comment.
It is kind of weird to have a "RepliesListProp" and a "RepliesListProps". This RepliesListProp seems to be a component not a prop so the name with Prop in the end does not make sense.



✅ RN - Nested Threads Lv1
Key details
Description
Acceptance Criteria
Guardrails
At this point only 1 nested level will be available.
*Nested Replies Multi Levels
Design Link: https://www.figma.com/design/z5ZdVlKEMmGIX4GVnjwfxA/BaseApp---NATIVE?node-id=7233-167121&t=jbYKzqIHwPMDjdiS-0
Approvd
https://app.approvd.io/silverlogic/BA/stories/39783
Demo:
https://www.loom.com/share/ee85c099a92f48478e7e21fa119093db