Conversation
|
No actionable comments were generated in the recent review. 🎉 WalkthroughRemoved test-settings import from social-auth config, added conditional injection of JWT Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
setup.cfg (1)
82-82: Specify at least a lower-bound version forsocial-auth-core.The bare
social-auth-corewith no version specifier is unusual and obscures intent. The previous== 4.5.4pin was also problematic —rest-social-auth(already in the samesocialauthextras group) requiressocial-auth-core (>=4.6.1, <5.0), meaning the old== 4.5.4pin was below that floor and could cause resolver conflicts. Setting a matching lower bound makes the requirement self-documenting and guards against accidental downgrade:♻️ Proposed fix
- social-auth-core + social-auth-core >= 4.6.1🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@setup.cfg` at line 82, Change the bare dependency entry "social-auth-core" to include a compatible lower bound (and optional upper bound) to match rest-social-auth's requirement; update the requirement to something like "social-auth-core>=4.6.1,<5.0" (or at least "social-auth-core>=4.6.1") so the package spec is explicit and avoids resolver conflicts.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@baseapp_social_auth/views.py`:
- Around line 69-75: Remove trailing whitespace on the blank lines surrounding
the JWT pipeline block in baseapp_social_auth/views.py: delete the
whitespace-only characters on the blank lines before and after the "if
hasattr(request.backend.strategy, 'jwt_token'):" / "if
hasattr(request.backend.strategy, 'jwt_refresh'):" block so there are truly
empty lines (fixing flake8 W293) while leaving the existing logic that sets
data["token"] and data["refresh"] intact.
---
Nitpick comments:
In `@setup.cfg`:
- Line 82: Change the bare dependency entry "social-auth-core" to include a
compatible lower bound (and optional upper bound) to match rest-social-auth's
requirement; update the requirement to something like
"social-auth-core>=4.6.1,<5.0" (or at least "social-auth-core>=4.6.1") so the
package spec is explicit and avoids resolver conflicts.
7331b3b to
a8f7169
Compare
update to social auth to work with Django 5.2 and to add jwt token to response
Summary by CodeRabbit
New Features
Chores