Skip to content

Conversation

@Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Dec 17, 2025

Needed for sillsdev/serval#832


This change is Reviewable

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)


src/SIL.Machine/PunctuationAnalysis/Chapter.cs line 14 at r1 (raw file):

        }

        public List<Verse> Verses { get; private set; }

It isn't a big deal, but private set; isn't necessary if the property is only ever set during construction.

@Enkidu93 Enkidu93 force-pushed the expose_chapter_numbers_when_strategizing branch from 4ce8412 to 1a02940 Compare December 17, 2025 23:40
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.60%. Comparing base (528dc72) to head (1a02940).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #369   +/-   ##
=======================================
  Coverage   72.60%   72.60%           
=======================================
  Files         423      423           
  Lines       35973    35975    +2     
  Branches     4965     4965           
=======================================
+ Hits        26117    26119    +2     
  Misses       8758     8758           
  Partials     1098     1098           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Enkidu93 Enkidu93 merged commit e044eb7 into master Dec 18, 2025
4 checks passed
@Enkidu93 Enkidu93 deleted the expose_chapter_numbers_when_strategizing branch December 18, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants