Skip to content

Conversation

@Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Dec 16, 2025

Partially resolves sillsdev/serval#844

Improvements include:

  • Add filter-by-books parameter to detector
  • Expose project name in error
  • Expected verse ref is always "" when the error type is ExtraVerse
  • Fix error verse ref bug + add tests

This change is Reviewable

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@Enkidu93 Enkidu93 force-pushed the usfm_versification_error_detection_improvements branch from 588ff3b to 9015d9e Compare December 17, 2025 17:57
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 87.09677% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.60%. Comparing base (ceef559) to head (9015d9e).

Files with missing lines Patch % Lines
...a/ParatextProjectVersificationErrorDetectorBase.cs 60.00% 1 Missing and 1 partial ⚠️
....Machine/Corpora/UsfmVersificationErrorDetector.cs 92.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
+ Coverage   72.52%   72.60%   +0.07%     
==========================================
  Files         423      423              
  Lines       35953    35973      +20     
  Branches     4964     4965       +1     
==========================================
+ Hits        26076    26117      +41     
+ Misses       8781     8758      -23     
- Partials     1096     1098       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Enkidu93 Enkidu93 merged commit 528dc72 into master Dec 17, 2025
4 checks passed
@Enkidu93 Enkidu93 deleted the usfm_versification_error_detection_improvements branch December 17, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvements to build warnings

4 participants