Do not reset chapter one when it contains duplicate id tags #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmachapman
force-pushed
the
duplicate_id_tags
branch
from
da2102b to
bd2ae70
Compare
pmachapman
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #365 +/- ##
=======================================
Coverage 72.51% 72.52%
=======================================
Files 423 423
Lines 35945 35948 +3
Branches 4962 4963 +1
=======================================
+ Hits 26066 26070 +4
Misses 8781 8781
+ Partials 1098 1097 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddaspit
approved these changes
Dec 10, 2025
Contributor
ddaspit
left a comment
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @pmachapman)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of sillsdev/machine.py#244 (sillsdev/machine.py#251).
This change is