Skip to content

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Dec 3, 2025

Fixes sillsdev/serval#822


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.51%. Comparing base (7651a39) to head (f2dbc2c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #361   +/-   ##
=======================================
  Coverage   72.51%   72.51%           
=======================================
  Files         423      423           
  Lines       35945    35945           
  Branches     4962     4962           
=======================================
  Hits        26066    26066           
  Misses       8781     8781           
  Partials     1098     1098           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops 😵 - thank you for fixing this, Peter. I'm surprised we didn't catch this earlier given that I totally flip-flopped things. Could you add a test to cover this?

@Enkidu93 reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@pmachapman pmachapman force-pushed the fix_surrogate_pair_handling branch from 99887c2 to f2dbc2c Compare December 7, 2025 22:24
Copy link
Collaborator Author

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done - added a unit test which breaks on master with the crash.

Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @ddaspit)

Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@Enkidu93 reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@Enkidu93
Copy link
Collaborator

Enkidu93 commented Dec 8, 2025

I'm going to go ahead and merge this so it'll be included in the new Machine version.

@Enkidu93 Enkidu93 merged commit 03621d1 into master Dec 8, 2025
4 checks passed
@Enkidu93 Enkidu93 deleted the fix_surrogate_pair_handling branch December 8, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure because of failed surrogate pair handling

4 participants