Skip to content

Add missing change from PR#937#939

Merged
chrisvire merged 1 commit intosillsdev:mainfrom
chrisvire:fix/apple-touch-icon
Feb 11, 2026
Merged

Add missing change from PR#937#939
chrisvire merged 1 commit intosillsdev:mainfrom
chrisvire:fix/apple-touch-icon

Conversation

@chrisvire
Copy link
Member

@chrisvire chrisvire commented Feb 11, 2026

This change was still in my local changes. I had thought it was included in #937

Summary by CodeRabbit

  • Bug Fixes
    • Fixed error handling for missing Android icons during apple-touch-icon.png generation. The system now consistently reports errors instead of selectively based on verbosity settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2026

📝 Walkthrough

Walkthrough

Modified error-handling logic in the Android icon validation process for apple-touch-icon.png generation. The change removes the verbose-dependent conditional, ensuring errors are always thrown when a suitable Android icon is unavailable, rather than only in verbose mode.

Changes

Cohort / File(s) Summary
Error Handling Logic
convert/convertMedia.ts
Removed verbose conditional from Android icon validation; error now always throws when no suitable icon exists for apple-touch-icon.png fallback generation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 Always throw, no looking back,
Remove the verbose gray and black,
Errors now shine crystal clear,
No more silence, no more fear! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title references a specific PR (#937) and indicates it's adding a missing change from that PR, which aligns with the modification to error handling in convertMedia.ts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chrisvire chrisvire merged commit 4b35cd5 into sillsdev:main Feb 11, 2026
4 checks passed
@chrisvire chrisvire deleted the fix/apple-touch-icon branch February 11, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant