Skip to content

Conversation

@BarbossHack
Copy link

First time contributor checklist

Contributor checklist

  • Desktop, Linux (fedora 42)
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

"split" in diff.attribute_name.lower()

diff.attribute_name is str | None, we should avoid failure by checking if not None before

and not is_meta_attr

It is a duplicate (already checked in this condition), can be safely removed

return True

This function does not return bool, but list[XmlDifference]. If there is no difference, just return an empty list []

children1_by_tag: dict[str, list[Element]] = {}

Just add some type annotation where it couldn't be infered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant