Skip to content

Conversation

@benediktjohannes
Copy link
Contributor

Fixes typing: IMPORTANT this is not a translation change, this is an internal change of the value field for the translations

Contributor checklist
[ x] I am following the Code Style Guidelines
[ x] My contribution is fully baked and ready to be merged as is
[ x] I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax
Description
Fixes typing: Important this is not a translation change, this is an internal change of the value field for the translations - another important thing to mention: This (probably) has to be changed in all language translation files as well and also in the general value context if it's wrong there as well and copied

Fixes typing: Important this is not a translation change, this is an internal change of the value field for the translations - another important thing to mention: This (probably) has to be changed in all language translation files as well and also in the general value context if it's wrong there as well and copied
Copy link
Contributor

@mtang-signal mtang-signal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here - will need to update where in the codebase this is called from (I think a fragment). All the translated files will automatically update so nothing further for you to do on that specific avenue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants