This repository was archived by the owner on Dec 19, 2020. It is now read-only.
add wit clean
#85
Open
add wit clean
#85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samh-sifive
reviewed
Jun 13, 2019
| print("wit {}".format(version)) | ||
|
|
||
|
|
||
| def clean(ws, args) -> None: |
Contributor
There was a problem hiding this comment.
See my comment in the wit foreach PR -- Unfortunately wit-manifest.json isn't a reliable indicator of package-ness. Iterating through the packages from the wit resolution algorithm is the safest way to do this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if there is much of a demand for a
wit cleancommand, but here's some code.It currently only removes workspace subdirectories that aren't packages.
Should it also
git reset --hard HEADpackages? If it does, people could lose important work to their uncommitted manifest changes.Or maybe we do
git reset --hard HEADbut confirm first if that includes resetting manifests?