Skip to content

Conversation

@Killusions
Copy link
Member

Only for testing #752


@Killusions Killusions marked this pull request as draft January 29, 2026 10:09
@Killusions Killusions changed the base branch from main to release/48.x January 29, 2026 10:10
@gemini-code-assist
Copy link

Summary of Changes

Hello @Killusions, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the UI component library by integrating AG Grid with a custom Element theme, providing robust data table functionalities. It also refines existing chart components for more efficient theme switching and optimizes select component filtering. Additionally, a new versioning system has been introduced for the documentation site, improving its maintainability and user experience.

Highlights

  • AG Grid Integration: Introduced a comprehensive integration of AG Grid with a custom Element design system theme, including custom components for date input and empty state overlays, and various styling parts for checkboxes, radios, toggles, pagination, pinning, skeleton loaders, text filters, and icons.
  • Chart Theming Improvement: Implemented a new themeSwitch() method for charts that allows changing themes without a full chart reload, improving performance and user experience. The old resetChart() method has been deprecated.
  • Select Component Filter Logic: Refactored the filtering logic within the SiSelectComplexOptionsDirective and SiSelectSimpleOptionsDirective to use computed signals, ensuring that filters are correctly applied when options are dynamically updated.
  • Documentation Versioning: Added a new JavaScript file (version-selector.js) and an example JSON (versions.example.json) to enable versioned documentation with auto-detection, enhancing the navigation and accessibility of different documentation versions.
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/publish-documentation.yaml
    • .github/workflows/release.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Killusions Killusions force-pushed the chore/add-versioned-documentation-with-auto-detection-in-docs-v48 branch from dd9d516 to 5d1243a Compare January 29, 2026 10:11
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a version selector for the documentation, which is a great addition. The implementation is mostly solid, fetching version information from a versions.json file and dynamically building the UI. I've identified a couple of areas for improvement in the new version-selector.js script: one related to removing some dead code for better maintainability, and a more important one to prevent a potential Cross-Site Scripting (XSS) vulnerability by escaping data before rendering it as HTML. The dependency updates seem correct.

@github-actions
Copy link

@Killusions
Copy link
Member Author

Works, closing again

@Killusions Killusions closed this Jan 29, 2026
@Killusions Killusions reopened this Jan 29, 2026
@Killusions Killusions force-pushed the chore/add-versioned-documentation-with-auto-detection-in-docs-v48 branch from 5d1243a to ab98005 Compare January 29, 2026 18:20
@github-actions
Copy link

Code Coverage

@Killusions Killusions closed this Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants