Skip to content

Conversation

@Killusions
Copy link
Member

@Killusions Killusions commented Jan 9, 2026

Only for testing #752


@gemini-code-assist
Copy link

Summary of Changes

Hello @Killusions, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a comprehensive system for managing and serving versioned documentation. It includes a backend script to merge and sort documentation version metadata, ensuring all available versions are correctly represented. Additionally, a frontend script automatically redirects users to the latest documentation version, improving navigation and ensuring consistent access to up-to-date content.

Highlights

  • Version Metadata Management Script: A new Node.js script (.github/scripts/merge-versions.mjs) has been added to manage and merge documentation version metadata (versions.json). This script ensures proper sorting and deduplication of 'latest', 'preview', and specific 'vX' versions, which is crucial for maintaining an accurate version selector.
  • Client-Side Version Redirection: A new JavaScript file (docs/_src/js/version-redirect.js) has been introduced to automatically redirect users to the /latest/ version of the documentation if they access a non-versioned path or the root. This enhances user experience by ensuring they always land on the most current documentation by default.
  • MkDocs Integration: The mkdocs.yml configuration has been updated to include the new version-redirect.js script in its extra_javascript section. This integration ensures that the client-side version redirection logic is active on the deployed documentation site.
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/publish-documentation.yaml
    • .github/workflows/release.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces versioning for the documentation by adding two new scripts and updating the mkdocs.yml configuration. A Node.js script (merge-versions.mjs) is added to merge and sort documentation versions, and a client-side JavaScript file (version-redirect.js) handles redirection to the correct versioned path.

The changes are well-implemented. The redirect script is robust, and the merge script correctly handles different version formats and edge cases. I've provided a couple of suggestions for the merge-versions.mjs script and one for version-redirect.js to improve code maintainability and readability by reducing duplication and simplifying complex conditions. Overall, this is a solid contribution.

@Killusions Killusions force-pushed the chore/add-versioned-documentation-with-auto-detection-in-docs-v48 branch 4 times, most recently from 88ac6b3 to 271749a Compare January 9, 2026 19:41
@Killusions Killusions force-pushed the chore/add-versioned-documentation-with-auto-detection-in-docs-v48 branch 3 times, most recently from a7fd116 to 03555ac Compare January 16, 2026 09:53
@Killusions
Copy link
Member Author

Tested and works, closing

@Killusions Killusions closed this Jan 16, 2026
@Killusions Killusions reopened this Jan 21, 2026
@Killusions Killusions force-pushed the chore/add-versioned-documentation-with-auto-detection-in-docs-v48 branch 2 times, most recently from 5b79581 to 5309317 Compare January 21, 2026 16:23
@Killusions Killusions changed the base branch from main to release/48.x January 21, 2026 16:30
@Killusions Killusions force-pushed the chore/add-versioned-documentation-with-auto-detection-in-docs-v48 branch from 5309317 to 138daec Compare January 21, 2026 16:31
@github-actions
Copy link

@Killusions Killusions force-pushed the chore/add-versioned-documentation-with-auto-detection-in-docs-v48 branch 7 times, most recently from 6edc2fd to bf8da97 Compare January 22, 2026 09:42
@Killusions
Copy link
Member Author

Seems to still work, closing

@Killusions Killusions closed this Jan 22, 2026
@Killusions Killusions reopened this Jan 22, 2026
@Killusions Killusions force-pushed the chore/add-versioned-documentation-with-auto-detection-in-docs-v48 branch from bf8da97 to ac9696d Compare January 22, 2026 11:49
@Killusions Killusions force-pushed the chore/add-versioned-documentation-with-auto-detection-in-docs-v48 branch from ac9696d to 97de94a Compare January 22, 2026 11:50
@github-actions
Copy link

Code Coverage

@Killusions
Copy link
Member Author

Works, closing again

@Killusions Killusions closed this Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants