Skip to content

Conversation

@joyalgeorgekj
Copy link
Contributor

Description

Came here to put my profile but found some problems so I solved it also added my profile too.

Problems Solved

  • There was this bug of not properly controlling theme when user first visit the website the theme icon has the moon icon meaning the theme should be dark but it still had the light theme and you have to press the theme toggle button twice to change the theme to dark.

  • Changed the defaultAvatar.png to defaultAvatar.webp.

  • There was a commented handle for user image not found but the implementation was wrong I have solved it and added the defaultAvatar as the default if user image not found.

  • added ID for search bar and filter dropdown for better form control and SEO.

Related Issues

  • Problems solved was not found in issues section

Changes Proposed

  • Better Theme control and Removed the bug from it.

  • Default Image added.

Checklist

  • I have read and followed the Contribution Guidelines.
  • All new and existing tests passed.
  • I have updated the documentation to reflect the changes I've made.
  • My code follows the code style of this project.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Canva Link to the Solution

Note to reviewers

Added comment to the code so that others can modify and understand the code.

@vercel
Copy link

vercel bot commented Jul 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-find ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2025 0:35am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Joyal-George-KJ! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.

@joyalgeorgekj
Copy link
Contributor Author

@shyamtawli Requesting Review.

@shyamtawli
Copy link
Owner

@Joyal-George-KJ I am not able to change theme, have a look

@joyalgeorgekj
Copy link
Contributor Author

@Joyal-George-KJ I am not able to change theme, have a look

@shyamtawli Sorry for wasting your time it was caused by my negligence. Forgot to pass props to the toggle hook. Ready for the review now and Tested everything that I changed.

  • Default Profile Picture Implementation - Done.
  • Console Errors - None.
  • Theme Toggle Checked - Done.

@shyamtawli shyamtawli merged commit 01f926b into shyamtawli:master Jul 14, 2025
3 checks passed
@shyamtawli
Copy link
Owner

@Joyal-George-KJ Thanks and sorry for late response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants