Wrap sortable's beforeStop; make sure all items are placed back#27
Open
FeepingCreature wants to merge 1 commit intoshvetsgroup:masterfrom
Open
Wrap sortable's beforeStop; make sure all items are placed back#27FeepingCreature wants to merge 1 commit intoshvetsgroup:masterfrom
FeepingCreature wants to merge 1 commit intoshvetsgroup:masterfrom
Conversation
…eir original position in the event that the user calls sortable.cancel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure all items are placed back in their original position in the event that the user calls sortable.cancel.
Fixes an issue where cancel is called from beforeStop to move the items back to wherever they came from, leading to the dragged item getting moved back but any additional items being left to linger in position: absolute state.