vm #63
Draft
vm #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also improve error messages in `compile_2_arg_call`.
Also add compilers for some arithmetic and comparison operators.
Instead hold onto an `Rc` to the instructions and pass that to the runtime.
To help with implementing funcall later.
This differentiates the `defun` keyword which is the name of the function being called, from the name of the defun being compiled.
They were both complaining about different `j`s earlier.
This will be needed when implementing `funcall` on them.
Without this a `Machine` instance that has all the state won't be available to make `funcall`s on.
Because the VM doesn't support that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.