Skip to content

SG-21701 Replace instances of Shotgun strings in .py files in all tk-…#29

Open
zamu5 wants to merge 2 commits intomasterfrom
SG-21701-replace_shotgun_instances
Open

SG-21701 Replace instances of Shotgun strings in .py files in all tk-…#29
zamu5 wants to merge 2 commits intomasterfrom
SG-21701-replace_shotgun_instances

Conversation

@zamu5
Copy link
Contributor

@zamu5 zamu5 commented Mar 26, 2021

…* repos with "SG"

@zamu5 zamu5 requested a review from thebeeland March 26, 2021 22:52
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 5, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@zamu5 zamu5 requested a review from jfboismenu May 12, 2021 18:16
Copy link
Contributor

@jfboismenu jfboismenu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I suggest a small change in order to make sure we remain backward compatible?

Co-authored-by: Jean-François Boismenu <jfboismenu@users.noreply.github.com>
"Shotgun Save As..."
# try to launch "SG Save As" command if we have it:
save_as_cmd = (
tank.platform.current_engine().commands.get("SG Save As...") or
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line over-indented for hanging indent
line break after binary operator

save_as_cmd = tank.platform.current_engine().commands.get(
"Shotgun Save As..."
# try to launch "SG Save As" command if we have it:
save_as_cmd = (
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black would make changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants