Skip to content

Comments

amyboardweb: wave preset UI + reliable wave state sync#685

Merged
bwhitman merged 1 commit intomainfrom
codex/amyboardweb-wave-preset-sync
Feb 20, 2026
Merged

amyboardweb: wave preset UI + reliable wave state sync#685
bwhitman merged 1 commit intomainfrom
codex/amyboardweb-wave-preset-sync

Conversation

@bwhitman
Copy link
Collaborator

@bwhitman bwhitman commented Feb 20, 2026

Summary

  • add PCM to wave options and generate PCM/WAVETABLE preset lists from pcm_tiny.h
  • make wave labels clickable (PCM/WAVETABLE) with compact preset popup + underline styling
  • persist wave preset selection in knob state and restore it via patch parsing
  • refresh patches.txt editor view after writes and reset editor scroll to top-left
  • simplify load/write flow so set_knobs_from_patch_number remains the source of knob state truth
  • fix LFO wave restore so imported/loaded v2w* values are preserved instead of snapping to triangle

Validation

  • syntax checks:
    • node --check tulip/amyboardweb/static/editor_knobs.js
    • node --check tulip/amyboardweb/static/amy_parameters.js
    • node --check tulip/amyboardweb/static/spss.js
  • manually verified behavior with env load + patches.txt rewrite flow

@bwhitman bwhitman merged commit 14f1183 into main Feb 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant