Skip to content

feat: Compatible with product bundle #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MalteJanz merged 2 commits into from
Jan 23, 2026
Merged

feat: Compatible with product bundle #113

MalteJanz merged 2 commits into from
Jan 23, 2026

Conversation

@tamvt
Copy link
Contributor

@tamvt tamvt commented Jan 12, 2026 •
edited by vienthuong
Loading

In this PR:

  • We need to migrate product states <-> product type and product type <-> product type
  • Product type PR: https://github.com/shopware/shopware/pull/13554/files
  • We need to exclude products with type grouped_bundle when migrating because the product bundles are not yet compatible with MIG yet.

@tamvt tamvt self-assigned this Jan 12, 2026
@tamvt tamvt linked an issue Jan 12, 2026 that may be closed by this pull request
Compatible with migration assistant shopware/shopware#13167
Closed
@tamvt tamvt changed the title feat: Compatible with migration assistant feat: Compatible with product bundle Jan 12, 2026
@tamvt tamvt marked this pull request as draft January 12, 2026 10:39
@tamvt tamvt force-pushed the 13167-compatible-with-migration-assistant branch 2 times, most recently from 54eaaea to fc9865c Compare January 16, 2026 08:22
@tamvt tamvt marked this pull request as ready for review January 16, 2026 08:42
@larskemper larskemper requested review from a team, DennisGarding, MalteJanz, ennasus4sun, jozsefdamokos, larskemper and vintagesucks and removed request for a team January 16, 2026 15:00
MalteJanz
MalteJanz requested changes Jan 19, 2026
View reviewed changes
Copy link
Contributor

@MalteJanz MalteJanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reaching out and taking care of this change 👍 . But I think we need to discuss a little further about the chosen approach and figure out a more robust one 🙂

@tamvt tamvt requested a review from vienthuong January 20, 2026 02:52
@MalteJanz MalteJanz mentioned this pull request Jan 20, 2026
Merged
@tamvt tamvt force-pushed the 13167-compatible-with-migration-assistant branch from fc9865c to ed932e4 Compare January 22, 2026 05:10
@tamvt tamvt requested a review from MalteJanz January 22, 2026 10:21
MalteJanz
MalteJanz reviewed Jan 22, 2026
View reviewed changes
@tamvt tamvt force-pushed the 13167-compatible-with-migration-assistant branch 2 times, most recently from b34ad82 to f7e1433 Compare January 23, 2026 04:03
MalteJanz
MalteJanz reviewed Jan 23, 2026
View reviewed changes
MalteJanz
MalteJanz reviewed Jan 23, 2026
View reviewed changes
@tamvt tamvt force-pushed the 13167-compatible-with-migration-assistant branch from f7e1433 to 0d4d57b Compare January 23, 2026 08:16
@tamvt tamvt requested a review from MalteJanz January 23, 2026 08:26
@MalteJanz MalteJanz merged commit 1704a1b into trunk Jan 23, 2026
7 checks passed
@MalteJanz MalteJanz deleted the 13167-compatible-with-migration-assistant branch January 23, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MalteJanz MalteJanz MalteJanz approved these changes

@vienthuong vienthuong vienthuong approved these changes

@nguyenytran nguyenytran nguyenytran approved these changes

@larskemper larskemper larskemper approved these changes

@jozsefdamokos jozsefdamokos Awaiting requested review from jozsefdamokos jozsefdamokos was automatically assigned from shopware/product-cc-after-sales

@DennisGarding DennisGarding Awaiting requested review from DennisGarding DennisGarding was automatically assigned from shopware/product-cc-after-sales

@vintagesucks vintagesucks Awaiting requested review from vintagesucks vintagesucks was automatically assigned from shopware/product-cc-after-sales

@ennasus4sun ennasus4sun Awaiting requested review from ennasus4sun ennasus4sun was automatically assigned from shopware/product-cc-after-sales

Assignees

@tamvt tamvt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compatible with migration assistant

6 participants

@tamvt @MalteJanz @vienthuong @nguyenytran @larskemper