restart sub p (reopened for review)#878
Merged
shocknet-justin merged 2 commits intomasterfrom Feb 17, 2026
Merged
Conversation
Merged
Member
Author
Fixed IssuesOriginal bugs causing crashes:
Fixes applied:
@boufni95 Ready for review |
shocknet-justin
force-pushed
the
master
branch
from
a299453 to
3389045
Compare
- Fix event listener memory leak by removing all listeners before restart - Properly cleanup old process with SIGTERM before forking new one - Fix Stop() to actually kill process (was using kill(0) which only checks existence) - Store callbacks in instance to avoid re-attaching listeners on restart - Add isShuttingDown flag to prevent restart when stopping intentionally - Add 100ms delay before restart to ensure clean process termination - Check if process is killed before sending messages - Update Reset() to store new settings for future restarts Co-authored-by: Cursor <cursoragent@cursor.com>
shocknet-justin
force-pushed
the
restart-sub-process
branch
from
95c0e0d to
c3e3f99
Compare
boufni95
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opening for review after unmerging due to crashes.
Original PR: #877
Issues found:
kill(0)only checks if process exists, doesn't kill itNeeds fixes before merging.
Made with Cursor