bug fixes and avoiding deprecation warnings#2
Open
michaelpradel wants to merge 1 commit intoshirgur:masterfrom
Open
bug fixes and avoiding deprecation warnings#2michaelpradel wants to merge 1 commit intoshirgur:masterfrom
michaelpradel wants to merge 1 commit intoshirgur:masterfrom
Conversation
… and Pytorch 1.0.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running Train.py with Python 3.6 and Pytorch 1.0.1 results in several deprecation warnings due to API changes, and eventually crashes with a TypeError (see below). This commit updates the code to Python 3.6 and Pytorch 1.0.1. Afterwards, it runs without any warnings or other problems.
Warnings:
PointerNet/PointerNet.py:105: UserWarning: nn.init.uniform is now deprecated in favor of nn.init.uniform_.
nn.init.uniform(self.V, -1, 1)
PointerNet/PointerNet.py:290: UserWarning: nn.init.uniform is now deprecated in favor of nn.init.uniform_.
nn.init.uniform(self.decoder_input0, -1, 1)
Trace of crash:
...
File "PointerNet/PointerNet.py", line 312, in forward
decoder_hidden0 = (torch.cat(encoder_hidden[0][-2:], dim=-1),
TypeError: cat(): argument 'tensors' (position 1) must be tuple of Tensors, not Tensor