[ROS-O] drop deprecated use of boost _1, _2#239
Open
v4hn wants to merge 1 commit intoshadow-robot:noetic-develfrom
Open
[ROS-O] drop deprecated use of boost _1, _2#239v4hn wants to merge 1 commit intoshadow-robot:noetic-develfrom
v4hn wants to merge 1 commit intoshadow-robot:noetic-develfrom
Conversation
The symbols have always been used through implicit includes from ros_comm, but ROS-O considers changing these includes right now because of excessive deprecation warnings building all of ROS. ros-o/ros_comm#3 (copyright updates are enforced by Shadow's CI)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The symbols have always been used through implicit includes from
ros_comm, but ROS-O considers changing these includes right now because
of excessive deprecation warnings building all of ROS.
ros-o/ros_comm#3
Without this noetic-compatible patch, these packages will fail to build with ROS-O, e.g., on Ubuntu 22.04, 24.04 and similar systems, in the near future.
See here for similar changes in the shadow-robot stack:
shadow-robot/sr-ros-interface-ethercat#267