Skip initialisation with zero authsources.#7
Open
thijskh wants to merge 1 commit intosgomez:masterfrom
Open
Conversation
This allows me to include the bundle in my project, including changes to the various files and use twig fucntions as conditionals, but only activate it for deploys that will be using SSP authn. This change basically allows you to comment out/leave out the ssp_guard config in app/config/config.yml. If you do so, your project will just work and the twig helpers will tell you that there are 0 authsources. It is also then not necessary that the installation_path of ssp exists. It leaves enable/disable configuration of the bundle in one place.
Contributor
Author
|
The diff looks larger than it is - it's basically the addition of an if block. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows me to include the bundle in my project, including changes
to the various files and use twig fucntions as conditionals, but only
activate it for deploys that will be using SSP authn. This change
basically allows you to comment out/leave out the ssp_guard config in
app/config/config.yml. If you do so, your project will just work and
the twig helpers will tell you that there are 0 authsources. It is
also then not necessary that the installation_path of ssp exists.
It leaves enable/disable configuration of the bundle in one place.