Add support for terminationGracePeriodSeconds on deployment#53
Closed
gustaff-weldon wants to merge 1 commit intosftpgo:mainfrom
Closed
Add support for terminationGracePeriodSeconds on deployment#53gustaff-weldon wants to merge 1 commit intosftpgo:mainfrom
gustaff-weldon wants to merge 1 commit intosftpgo:mainfrom
Conversation
|
|
Contributor
|
Sorry — I didn’t see your PR #53 before opening mine (#55). I implemented these changes earlier and just pushed; my PR also fixes the 0 value handling. Would you like me to combine them into a single PR (and preserve your commits), or would you prefer I update mine to include anything missing from yours? |
Member
|
Closing in favor of #55 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to benefit from
SFTPGO_GRACE_TIMEvalues higher than default 30 seconds that Kubernetes waits before sending SIGKILL to Pod, ability to set custom terminationGracePeriodSeconds is needed.