Open
Conversation
pyoo provides FILTER_PDF_EXPORT which users may mistake as being the (non-existing) general PDF export filter, whereas in fact it is the writer export filter, which results in an "SfxBaseModel error" 0x81a when it is used for anything else but writer documents. Provide FILTER_WRITER_PDF_EXPORT and FILTER_CALC_PDF_EXPORT so that the two most used export filters are there, and their sheer presence under these names alerts the user to use the right one (or look at their value, and infer what to use for "math", "impress" etc.). FILTER_PDF_EXPORT could be deprecated but is left in for compatibility reasons for now.
Contributor
|
Hi, unfortunately I can no longer merge this pull request as I no longer work in Seznam. I merged this change to a fork in my personal profile and uploaded a new version to PyPI. Thank you and sorry for the long inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyoo provides FILTER_PDF_EXPORT which users may mistake as being the
(non-existing) general PDF export filter, whereas in fact it is the
writer export filter, which results in an "SfxBaseModel error" 0x81a
when it is used for anything else but writer documents.
Provide FILTER_WRITER_PDF_EXPORT and FILTER_CALC_PDF_EXPORT so that the
two most used export filters are there, and their sheer presence under
these names alerts the user to use the right one (or look at their
value, and infer what to use for "math", "impress" etc.).
FILTER_PDF_EXPORT could be deprecated but is left in for compatibility
reasons for now.