fix: return cancun

[insider89]

Summary by Sourcery

Add support for the Cancun fork time to the Besu genesis configuration and ensure related bootstrap tests include the new field.

New Features:

• Include a cancunTime field in the Besu genesis configuration with a default value.
• Extend bootstrap-related test fixtures to account for the new cancunTime configuration value.

Summary by cubic

Restores the cancunTime field in Besu genesis configs so Cancun fork activation is included in generated artifacts. Updates bootstrap tests to cover cancunTime.

• Bug Fixes
  • Added cancunTime to BesuGenesisConfig and the default values returned by BesuGenesisService.
  • Updated bootstrap genesis prompt and selective artifacts tests to include cancunTime in sample payloads.

^{Written for commit d311ba4. Summary will update automatically on new commits.}

[gemini-code-assist]

Summary of Changes

Hello @insider89, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates support for the upcoming Cancun upgrade by adding a cancunTime configuration parameter to the Besu genesis configuration. This involves updating the relevant type definitions, ensuring the new parameter is initialized correctly within the genesis service, and reflecting these changes in associated test files to maintain consistency and prepare for future functionality.

Highlights

• Configuration Update: Introduced the cancunTime property to the BesuGenesisConfig type, preparing for the Cancun upgrade.
• Test File Modifications: Updated test stubs and sample payloads in bootstrap.genesis-prompts.test.ts and bootstrap.selective-artifacts.test.ts to include the new cancunTime property, initialized to 0.
• Service Initialization: Modified besu-genesis.service.ts to initialize cancunTime to 0 within the createGenesisConfig method.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[github-actions]

To view in Slack, search for: 1766569849.172179

[cubic-dev-ai]

No issues found across 3 files

[gemini-code-assist]

Code Review

This pull request correctly adds support for the Cancun fork by introducing the cancunTime field into the Besu genesis configuration. The changes are consistently applied in the genesis service and its related tests. I have one suggestion in a test file to improve code clarity by reordering some existing properties to follow chronological order, which would be a good opportunity for a small cleanup.

[gemini-code-assist]

For better readability and to maintain consistency with the chronological order of Ethereum forks, it would be good to reorder these properties. The muirGlacierBlock fork occurred before the berlinBlock fork.

Suggested change

	berlinBlock: 0,
	muirGlacierBlock: 0,
	shanghaiTime: 0,
	cancunTime: 0,
	muirGlacierBlock: 0,
	berlinBlock: 0,
	shanghaiTime: 0,
	cancunTime: 0,