fix: enable cancun for besu genesis

[snigdha920]

We use the evm version cancun in the smart contracts now, needs to be enabled in besu too: https://github.com/settlemint/dalp/blob/8bb416dd927e78a47ee4de88eaeee844e751cc5b/kit/contracts/hardhat.config.ts#L12 the contracts use the MCOPY opcode (faster memory copy) included in the cancun upgrade

Summary by Sourcery

Enable configuration and default initialization of the Cancun fork activation time in the Besu genesis generation service.

New Features:

• Add support for specifying a Cancun activation time in Besu genesis configuration.

Bug Fixes:

• Ensure Besu genesis includes a Cancun time field initialized with a default value to avoid missing-fork configuration issues.

---

Summary by cubic

Enable Cancun fork activation in Besu genesis by adding cancunTime to the genesis config and initializing it to 0 by default. This lets networks set a Cancun activation time and prevents missing-fork configuration issues.

• Bug Fixes
  • Allow draft PRs to log in to GHCR by updating the workflow login condition.

^{Written for commit a6c439f. Summary will update automatically on new commits.}

Summary by Sourcery

Enable Besu genesis configurations to set a Cancun fork activation time and adjust CI to allow container registry login from draft pull requests.

New Features:

• Add Cancun activation time support to Besu genesis configuration.

Bug Fixes:

• Ensure Besu genesis includes a default Cancun activation time to avoid missing-fork configuration issues.

CI:

• Relax GitHub Container Registry login condition in QA workflow to run on both push and pull_request events, including drafts.

Tests:

• Update bootstrap CLI tests to cover the new Cancun activation time field in Besu genesis configs.

[gemini-code-assist]

Summary of Changes

Hello @snigdha920, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates support for the Cancun hardfork into Besu genesis configurations. It achieves this by adding a new parameter, "cancunTime", which allows specifying the activation timestamp for the Cancun upgrade. This change is essential for ensuring that Besu nodes can properly initialize and operate with the latest Ethereum protocol advancements, particularly those introduced by Cancun.

Highlights

• Cancun Upgrade Support: Introduced the "cancunTime" property to the "BesuGenesisConfig" interface, allowing for the configuration of the Cancun hardfork activation time within Besu genesis files.
• Default Cancun Activation: Set the default value for "cancunTime" to "0" when initializing a new Besu genesis configuration, ensuring Cancun is enabled by default or can be explicitly configured.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for the Cancun fork in the Besu genesis generation by including the cancunTime field. The implementation adds the field to the BesuGenesisConfig type and initializes it with a default value of 0 in the BesuGenesisService. This correctly addresses the issue of missing fork configuration. My review includes a suggestion to also allow cancunTime to be configurable to fully align with the PR's stated goal of enabling configuration, which would make the service more flexible.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[github-actions]

To view in Slack, search for: 1765097386.534839

[cubic-dev-ai]

No issues found across 4 files