Skip to content

Conversation

@simonwuelker
Copy link
Contributor

@simonwuelker simonwuelker commented Jan 13, 2026

This action will automatically assign the "breaking" or "non-breaking" to PRs based on the output of cargo-semver-checks.

Testing: I opened two test PRs in my fork, which were labelled correctly (https://github.com/simonwuelker/html5ever/pulls)

Copy link
Contributor

@nicoburns nicoburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea. Do we need some logic to also remove the other label?

I'm thinking of cases where a PR is pushed to, and it's breaking vs. non-breaking status changes...

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
@simonwuelker
Copy link
Contributor Author

I've added a line that removes both labels before assigning the new one.

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
@simonwuelker
Copy link
Contributor Author

Permissions work fine on my fork, so I think the job is (correctly) failing while the job is not in main.
I think I need special permission to merge this while the job is failing though?

@simonwuelker simonwuelker added this pull request to the merge queue Jan 13, 2026
Merged via the queue into servo:main with commit 9167933 Jan 13, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants