-
Notifications
You must be signed in to change notification settings - Fork 259
Relax <select> parser (WHATWG proposal)
#560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
9120820
Relax selector parsing
untitaker edf8499
fmt
untitaker 4f8c7bb
whoops
untitaker a29279e
Merge remote-tracking branch 'origin/main' into relaxed-selector-parsing
untitaker 6377dbe
bump html5lib-tests again
untitaker eb9401c
renamed methods
untitaker 6bb5ef8
fixup
untitaker 559b813
fix select state
untitaker 714eea6
fmt
untitaker 2c46bf4
remove xxx
untitaker 2c7511d
fix input case
untitaker ceb4db3
wip
untitaker 943a6de
select
untitaker 55288b6
select
untitaker 1b01d59
fmt
untitaker cc64b2c
clippy
untitaker 32ae61f
ignore failing selectedcontent tests
untitaker ad505ea
Merge branch 'main' into relaxed-selector-parsing
untitaker a407019
lint fix
untitaker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am currently running into issues when trying to bump servo to include this change, since
reparent_childreninternally callsNode::Appendand that throws an exception when the new parent is a document node.Should the old children of the selected content really end up as children of the document? That seems odd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I think that's broken, added an issue here #712