Fix drag-and-drop file open corrupting backupFilename#9
Merged
borislav-angelov merged 1 commit intomasterfrom Feb 24, 2026
Merged
Fix drag-and-drop file open corrupting backupFilename#9borislav-angelov merged 1 commit intomasterfrom
borislav-angelov merged 1 commit intomasterfrom
Conversation
On macOS, dragging a file onto the window could trigger both the DropOverlay drop handler and a QEvent::FileOpen via AppDelegate, potentially with different file paths. Because openBackupFile() set backupFilename before validating the file, a stale or unreadable path from the FileOpen event could silently overwrite backupFilename while the UI continued to display the correct filename from the drop. Move backupFilename assignment after the isReadable() check so invalid paths never corrupt state. Remove the duplicate QEvent::FileOpen handler from MainWindow::event() since AppDelegate already handles it.
developeritsme
requested review from
arminkardovic,
borislav-angelov and
yani-
borislav-angelov
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, dragging a file onto the window could trigger both the DropOverlay drop handler and a QEvent::FileOpen via AppDelegate, potentially with different file paths. Because openBackupFile() set backupFilename before validating the file, a stale or unreadable path from the FileOpen event could silently overwrite backupFilename while the UI continued to display the correct filename from the drop.
Move backupFilename assignment after the isReadable() check so invalid paths never corrupt state. Remove the duplicate QEvent::FileOpen handler from MainWindow::event() since AppDelegate already handles it.