Make parseEscape errors more informative#37
Open
lierdakil wants to merge 2 commits intoserokell:masterfrom
Open
Make parseEscape errors more informative#37lierdakil wants to merge 2 commits intoserokell:masterfrom
lierdakil wants to merge 2 commits intoserokell:masterfrom
Conversation
Allow partial parses in 'parseEscapes', but use a greedy parser. Show the character escape that failed to parse and input position in the error message.
kirelagin
reviewed
Dec 29, 2021
Contributor
kirelagin
left a comment
kirelagin
left a comment
There was a problem hiding this comment.
The change looks good to me, but can you please add tests that exercise all the error conditions?
Contributor
Author
I've added a couple tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow partial parses in 'parseEscapes', but use a greedy parser. Show
the character escape that failed to parse and input position in the
error message.