Skip to content

Conversation

@Taka-Kazu
Copy link
Contributor

@Taka-Kazu Taka-Kazu commented Dec 11, 2025

ts-proto is the tool for generating .ts files from proto files.

@Taka-Kazu Taka-Kazu requested a review from Copilot December 11, 2025 09:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds TypeScript support to the project by introducing ts-proto, a tool for generating TypeScript files from proto definitions.

  • Adds ts-proto dependency for proto-to-TypeScript code generation
  • Adds TypeScript compiler as a dependency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Taka-Kazu Taka-Kazu requested a review from at-wat December 11, 2025 09:21
@Taka-Kazu
Copy link
Contributor Author

rxjs is required from some generated ts files.

Copy link
Member

@at-wat at-wat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write ts-proto version to /versions file.

&& echo "node grpc-tools $(npm view grpc-tools version)" >> /versions \

Also, please update the package lock file.

Copy link
Member

@at-wat at-wat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Taka-Kazu Taka-Kazu merged commit 6a8abd5 into master Dec 12, 2025
1 check passed
@Taka-Kazu Taka-Kazu deleted the support-typescript branch December 12, 2025 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants