sctp: fire onopen after COOKIE/COOKIE_ACK is completed #239
+12
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we fire onopen too early we might be sending data before other SCTP steps are finished. For example, with aiortc, this results in the datachannel connection not being established.
aconchillo
added a commit
to pipecat-ai/pipecat-esp32
that referenced
this pull request
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we fire onopen too early we might be sending data before other SCTP steps are finished. For example, with aiortc, this results in the datachannel connection not being established.
I'm not sure this is correct, but it seems to fix the issue I was having with
aiortc. That said, it seems to make sense to fireonopenafter everything is completed.