Replace custom parser with Protoc generation#1
Merged
Conversation
…generation This major refactoring removes the custom nom-based parser from protokit and simplifies the code generation pipeline to work directly with protoc's FileDescriptorSet output. Key changes: - Remove protokit_proto crate from the workspace - Remove parser and protoc feature flags from protokit_build - Create new DescriptorPool as a thin overlay on FileDescriptorSet - Rewrite code generation to work directly with protobuf descriptors - Simplify grpc.rs to use the new pool-based approach - Remove unused deps.rs and tabular.rs files - Update conformance and gendesc tools to use the simplified API The new architecture: 1. protoc generates FileDescriptorSet with fully resolved type names 2. DescriptorPool indexes types by FQN and detects circular references 3. CodeGenerator works directly with protobuf descriptor types This eliminates the complexity of the custom parser and AST translation layer while leveraging protoc's robust name resolution.
Fixed issues in merge_repeated: - Allow implicit whitespace separators in lists (e.g., [1 2 3]) - Allow semicolons as separators in lists - Check if comma is followed by field name before continuing to parse values This fixes comma-separated field syntax like "vals: 1, vals: 2" Removed repro test files that were only used for debugging: - repro_ext.rs - repro_list.rs - repro_p2.rs - repro_sep.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.