feat: add operations and configurations panels with entity tree restructure #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bburda
force-pushed
the
feat/add-operations-and-configuration
branch
from
26ac281 to
0c8fdd1
Compare
…ucture - Add ConfigurationPanel for viewing/editing ROS 2 parameters - Add OperationsPanel for invoking services and actions - Add ActionStatusPanel with auto-refresh for monitoring action goals - Restructure entity tree with virtual folders (data/operations/configurations) - Add lazy loading for virtual folder contents - Add empty state indicator for folders without content - Add detail views for service, action, and parameter entities - Extend sovd-api.ts with configurations and operations endpoints - Add new types for Parameter, Operation, ActionGoalStatus
bburda
force-pushed
the
feat/add-operations-and-configuration
branch
from
0c8fdd1 to
b6b6236
Compare
There was a problem hiding this comment.
Pull request overview
This pull request adds comprehensive configuration and operations management capabilities to the SOVD web UI by introducing three new panels (ConfigurationPanel, OperationsPanel, and ActionStatusPanel) and restructuring the entity tree with virtual folders for better organization of data, operations, and configurations.
Key Changes:
- Introduces virtual folder structure (data/, operations/, configurations/) for component organization
- Adds ROS 2 parameter viewing and editing with inline edit capabilities
- Implements service invocation and action goal management with status monitoring
- Extends API client with new endpoints for configurations and operations
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 18 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/types.ts | Adds comprehensive type definitions for Parameters, Operations, and ActionGoalStatus with proper TypeScript interfaces |
| src/lib/store.ts | Extends state management with configurations/operations state, virtual folder handling, and lazy loading logic |
| src/lib/sovd-api.ts | Implements API methods for configurations (ROS 2 parameters) and operations (services/actions) endpoints |
| src/components/OperationsPanel.tsx | New panel for invoking services and actions with form/JSON input modes and history tracking |
| src/components/OperationResponse.tsx | Renders operation responses with proper formatting for different data types |
| src/components/ConfigurationPanel.tsx | New panel for viewing and editing ROS 2 parameters with inline editing and type-specific inputs |
| src/components/ActionStatusPanel.tsx | Monitors action goal status with auto-refresh capability and progress indicators |
| src/components/EntityTreeNode.tsx | Updates tree node rendering to support virtual folders, operations, and parameters with appropriate icons |
| src/components/EntityDetailPanel.tsx | Refactors detail view with tabbed interface for components and specialized views for operations/parameters |
| src/components/DataFolderPanel.tsx | New panel for displaying topics within the data virtual folder |
| src/index.css | Adds custom animation for indeterminate progress bars and removes trailing whitespace |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add JSON validation before operation invoke with error display - Fix UUID regex to match standard format with hyphens - Add encodeURIComponent for goalId in API URL parameters - Return empty array instead of raw string on array parse error - Add accessibility attributes to editable parameter div (role, tabIndex, keyboard) - Add proper id/htmlFor and focus styling to auto-refresh checkbox - Replace native button with Button component for History toggle
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Issue
Type
Testing
Manual tests with demo
Checklist
npm run lint)npm run build)