feat: add signet and regtest networks#804
Draft
qlrd wants to merge 2 commits intoselfcustody:developfrom
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #804 +/- ##
===========================================
+ Coverage 97.31% 97.33% +0.01%
===========================================
Files 83 83
Lines 10576 10604 +28
===========================================
+ Hits 10292 10321 +29
+ Misses 284 283 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
qlrd
force-pushed
the
feat/signet-regtest
branch
from
7d43b00 to
9c17965
Compare
qlrd
force-pushed
the
feat/signet-regtest
branch
2 times, most recently
from
da921b7 to
2ace576
Compare
qlrd
force-pushed
the
feat/signet-regtest
branch
2 times, most recently
from
faabd78 to
8bab5ec
Compare
This commit add the options `signet` and `regtest` to `DefaultWallet` at `src/krux/krux_settings` as well `Signet` and `Regtest` names to `src/krux/wallet_settings`. To be in coherent with the change, it was added the options string to menubar as well added theme colors for it. feat
qlrd
force-pushed
the
feat/signet-regtest
branch
from
8bab5ec to
3d78c2b
Compare
This commit add tests on `Customize` menu button and change `Networks` from `Mainnet` to `Testnet/Signet/Regtest`.
qlrd
force-pushed
the
feat/signet-regtest
branch
from
3d78c2b to
6da98e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR add the options
signetandregtesttoDefaultWalletatsrc/krux/krux_settingsas wellSignetandRegtestnames tosrc/krux/wallet_settings. To be in coherent with the change, it was added the options string to menubar as well added theme colors for it.Changes made to:
Did you build the code and tested on device?
What is the purpose of this pull request?
Notes
Add these options do not alter the key generation on
networkchain (e.g.84h/0hor84h/1h) since the number1hdo not change fortestnet/signet/regtest). They're just an UX improvement for a new user, so he/she will not be messed up thinking was his/her error.