feat: Added native library for arm chips & constructor support for so…#11
Open
feat: Added native library for arm chips & constructor support for so…#11
Conversation
Introduced implicit conversions for rvec3 (from UnityEngine.Vector3), BodyID (to/from uint), and Shape (from PlaneShape). Added constructors for BodyID (from uint) and SphereShape (from float radius). Marked some methods as readonly for improved immutability and clarity.
Changed JPH_BodyInterface_GetBodyType to return BodyType instead of bool and updated its implementation to call the correct UnsafeBindings method.
Added implicit operators to convert rvec3 to and from System.Numerics.Vector3 and UnityEngine.Vector3. This improves interoperability between rvec3 and common vector types in .NET and Unity.
Introduced a new 'subType' property to the Shape class with aggressive inlining for improved performance. This provides an alternative to the existing GetSubType() method.
Grants the JoltWrapper assembly access to internal members of the Jolt namespace by adding an InternalsVisibleTo attribute.
The GetPosition method in BodyInterface is now marked as readonly, indicating it does not modify the state of the struct. This can improve code clarity and enable certain compiler optimizations.
Changed the return type of GetBodyType from bool to BodyType to match the expected return value from the underlying binding.
Introduced a gravity property to PhysicsSystem for easier access and assignment. Added InvalidBodyID constant to BodyID for invalid ID representation. Implemented implicit conversion from ObjectLayer to uint for convenience.
This reverts commit 0b252e9.
|
Currently, the library doesn't work on MacOS, as it only has a 64-bit version. Merging this PR will solve this problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…me types.