Conversation
src/client.js
Outdated
| * GitHub configuration. | ||
| */ | ||
|
|
||
| const config = { |
There was a problem hiding this comment.
No need to have this config object anymore. Just create a timeout constant (or defaultTimeout based on the next comment).
Besides that, as a suggestion, it could just be a default value in case the constructor does not receive a specified timeout value. You would have something like this:
constructor({ timeout, token, ...options }) {
this.github = new Octokit({
auth: token,
request: { timeout: timeout || defaultTimeout },
...options
});
}|
|
||
| err.status = 404; | ||
| throw err; | ||
| }); |
Jcc20
force-pushed
the
enhancement/ocktokit-upgrade
branch
2 times, most recently
from
aaa69dc to
f738ef5
Compare
bsonntag
reviewed
Mar 6, 2023
Jcc20
force-pushed
the
enhancement/ocktokit-upgrade
branch
from
f738ef5 to
41d5ff4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
octokitversion to the latest and updates the respective dependencies.It also updates some
octokitmethods according to latest version.