-
Notifications
You must be signed in to change notification settings - Fork 0
Switch on oss_lib for flask and configuration #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
maretskiy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, however there is one important comment
| port=app.config.get("PORT", 5000)) | ||
|
|
||
|
|
||
| if __name__ == "__main__": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should remain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? It is not used it is not used anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried `python availability/main.py' - this does not cause CLI to run.
Maybe there is another way to get flask started?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, you should start availability-api after installing the availability package because it provides two console scripts: availability-api and availability-watcher.
You can create your own virtualenv and install availability into it:
git clone https://github.com/seecloud/availability.git
cd availability
virtualenv .venv
.venv/bin/pip install .
And then run it:
.venv/bin/availability-api --help
So, we can create a special target in tox.ini to simplify this preparation of venv and it will look like:
tox -e venv -- availability-api --help
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works, thanks!
No description provided.