Skip to content

Conversation

@akscram
Copy link
Contributor

@akscram akscram commented Dec 27, 2016

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.6%) to 87.44% when pulling 88fb0f9 on config into 4ffe67e on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.6%) to 87.44% when pulling 88fb0f9 on config into 4ffe67e on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.6%) to 87.44% when pulling 11d6162 on config into 4ffe67e on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.6%) to 87.44% when pulling 33c6c99 on config into 4ffe67e on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.6%) to 91.584% when pulling 3dde249 on config into 4ffe67e on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.5%) to 91.542% when pulling 3729f68 on config into 4ffe67e on master.

Copy link
Contributor

@maretskiy maretskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however there is one important comment

port=app.config.get("PORT", 5000))


if __name__ == "__main__":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should remain

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? It is not used it is not used anyway.

Copy link
Contributor

@maretskiy maretskiy Dec 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried `python availability/main.py' - this does not cause CLI to run.
Maybe there is another way to get flask started?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, you should start availability-api after installing the availability package because it provides two console scripts: availability-api and availability-watcher.

You can create your own virtualenv and install availability into it:

git clone https://github.com/seecloud/availability.git
cd availability
virtualenv .venv
.venv/bin/pip install .

And then run it:

.venv/bin/availability-api --help

So, we can create a special target in tox.ini to simplify this preparation of venv and it will look like:

tox -e venv -- availability-api --help

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, thanks!

@coveralls
Copy link

Coverage Status

Coverage increased (+1.6%) to 91.626% when pulling da4d54f on config into c1af3a6 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.6%) to 91.626% when pulling 1fddef4 on config into 6c53b49 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.6%) to 91.626% when pulling 37e6a65 on config into 6204d1f on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants