Fix issue #14. Watcher got exception if starting with dead Elastic #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boris-42
requested changes
Dec 6, 2016
|
|
||
|
|
||
| def get_elasticsearch(check_availability=False): | ||
| """Return Elasticsearch instance. |
Member
There was a problem hiding this comment.
This method must raise Exception. It's very important.
Code that is using this method should handle exception
maretskiy
force-pushed
the
fix-issue-14
branch
from
0a6c5d9 to
c050c96
Compare
redixin
requested changes
Dec 23, 2016
| mesg = ("Failed to query Elasticsearch nodes %s: %s" | ||
| % (nodes, str(e))) | ||
| LOG.error(mesg) | ||
| raise StorageException(mesg) |
There was a problem hiding this comment.
This looks like ExceptionSpoofing antipattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.