Add block stale-ness check #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed my home node got stuck on a block with the connection it had, but continued to exchange ping and pongs. This adds a very basic check to see if blocks are being withheld from us by disconnecting from a peer if they have not sent a block to us for 20 minutes.
Owner
|
I've seen this too a couple of times. It doesn't really make sense to me. Seems fine to be rotating peers every now and again, but I wonder if at this point we should just introduce multi-peer messages handling. |
Contributor
Author
|
I think in that case we would still want to disconnect all connections if we haven't seen a block for a certain amount of time? Maybe it could be less aggressive in the first stale check (like 30 minutes), then move to something more aggressive? |
sedited
approved these changes
Dec 29, 2025
Owner
sedited
left a comment
sedited
left a comment
There was a problem hiding this comment.
Ran this for a bit and saw a few re-connects. The warning seems a bit harsh, since this will print even during normal block rate variations. Maybe relegate the log level to info?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed my home node got stuck on a block with the connection it had, but continued to exchange ping and pongs. This adds a very basic check to see if blocks are being withheld from us by disconnecting from a peer if they have not sent a block to us for 20 minutes.