-
Notifications
You must be signed in to change notification settings - Fork 33
add dev container for clone issue #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "ms-vscode.cpptools", | ||
| "ms-vscode.cmake-tools", | ||
| "twxs.cmake", | ||
| "ms-python.python", | ||
| "ms-python.vscode-pylance" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need only lldb, clang and cmake extensions. There is some fresh cool CMake extension with an LSP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+ clangd
lab/vtsh/Dockerfile
Outdated
| RUN apt-get update && apt-get install -y --no-install-recommends python3-pytest && rm -rf /var/lib/apt/lists/* | ||
| WORKDIR /workspace | ||
|
|
||
| ENV CC=gcc CXX=g++ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use Clang.
|
@e1turin, what do you think about it? |
|
I have some concerns that this image is not used in workflows and and therefore is not tested. |
lab/vtsh/Dockerfile
Outdated
|
|
||
| RUN update-ca-certificates | ||
|
|
||
| RUN apt-get update && apt-get install -y --no-install-recommends python3-pytest && rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why it is in separate layer?
| "ms-vscode.cpptools", | ||
| "ms-vscode.cmake-tools", | ||
| "twxs.cmake", | ||
| "ms-python.python", | ||
| "ms-python.vscode-pylance" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+ clangd
| @@ -0,0 +1,37 @@ | |||
| { | |||
| "name": "vtsh-linux", | |||
| "dockerComposeFile": "../docker-compose.yml", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason of docker-compose? Why not to use simple Dockerfile?
Yes, I think some tests should be provided. And instead of setting up lot's of dependencies manally, it whould be better to use prepared image (from current CI) with clang. |
|
i have a solve w/o docker-compose, FROM ubuntu and gcc, but there are problems with setting up the code lldb extension for debugging. It always returns the error "spawn cargo ENOENT" or "lldb-mi not found" when pressed debug button. Do you have some json configs or smth like that, to solve this issues ? |
|
How you can proof that your configuration works? |
No I have never faced the problem. I think you can find complete devcontainer setup for macos which may help. |
I consider this configuration to be very minimal—basically only for running and debugging. Therefore, I thought writing additional tests is unnecessary. I can confirm, however, that I’ve already completed the first lab and the CI test results matched those in the dev container. |
I was only able to make a little progress on solving this task. LLDB now launches, but there’s an issue with the external terminal—currently the terminal just idle and nothing happens. Can I hook up the old debug tool instead? If someone specifically needs LLDB, that person can set up the launch.json and Docker configuration correctly. Cause I ve done lab1 w\o lldb and cant remember problems with it |
|
I solved the issue with lldb and the inability to debug. The issue was described here: https://forums.docker.com/t/sys-ptrace-capability-for-linux-amd64/138482 Exactly the same error description. I couldn't find a solution; it's likely due to an incompatibility between m1 processors and Debian-based Docker. If I change FROM silkeh/clang:latest to FROM ubuntu:24.04 in Docker, everything works. What do you think about using a non-CI/CD image but still providing users with debugging capabilities? I haven't had any issues with Ubuntu during my work. |
mac os dont have sys call "clone", so mac users can use dev container in vccode