Fix error handling for non-Error objects in catch blocks#156
Merged
Fix error handling for non-Error objects in catch blocks#156
Conversation
* Initial plan * Add getErrorMessage helper and update error handling in catch blocks Co-authored-by: seanmcne <2292260+seanmcne@users.noreply.github.com> * Fix getErrorMessage to properly handle null/undefined values Co-authored-by: seanmcne <2292260+seanmcne@users.noreply.github.com> * Add safety handling for JSON.stringify to prevent circular reference errors Co-authored-by: seanmcne <2292260+seanmcne@users.noreply.github.com> * Add e.name fallback for Error objects to provide more meaningful messages Co-authored-by: seanmcne <2292260+seanmcne@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: seanmcne <2292260+seanmcne@users.noreply.github.com>
* Initial plan * Fix Number validation for settings with empty max values * Add undefined check to maxNumber handling based on code review feedback
seanmcne
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.