Skip to content

Conversation

@bbrcknl
Copy link
Collaborator

@bbrcknl bbrcknl commented Jan 5, 2026

No description provided.

Signed-off-by: b@brck.nl <b@brck.nl>
Signed-off-by: b@brck.nl <b@brck.nl>
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Preview your changes here

@bbrcknl bbrcknl requested a review from june-andronick January 5, 2026 02:00
Copy link
Contributor

@june-andronick june-andronick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Signed-off-by: b@brck.nl <b@brck.nl>
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Preview your changes here

Copy link
Member

@lsf37 lsf37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should do this (I mean the text/SVG part, the add/remove is fine of course). Logos should be logos and not text. If a member does not want to show their logo, we should make an SVG that shows text so the code remains uniform.

Also, why are we changing TUM?

@gernotheiser
Copy link
Member

the Apple logo is too big, it dominates the whole page.
And DornerWorks is the only founding member?
UNSW is also an endorsed service provider

@june-andronick
Copy link
Contributor

I don't think we should do this (I mean the text/SVG part, the add/remove is fine of course). Logos should be logos and not text. If a member does not want to show their logo, we should make an SVG that shows text so the code remains uniform.

Also, why are we changing TUM?

As members sign the new agreements, they can pick again whether they allow the use of their logo. In the case of TUM, we were told that the university has become more restrictive, hence no logo.

@june-andronick
Copy link
Contributor

the Apple logo is too big, it dominates the whole page.

This must be just the preview. It looks fine on the live page and that part hasn't changed (RTX also looks too big on the preview)

And DornerWorks is the only founding member? UNSW is also an endorsed service provider

UNSW appears as founding member and service provider in the preview for me. The other founding members (aside DW and UNSW) are now gone (or merged into another entity)

@gernotheiser
Copy link
Member

Ahh, I got confused. Because the "Founding Member" and "service provider" annotations are so far from the logo, they look like a page footer rather than an annotation of the member logo. Quite spaced at some of the other members too (eg Kry10) but it's less confusing as they aren't at the bottom of the page

@lsf37
Copy link
Member

lsf37 commented Jan 7, 2026

the Apple logo is too big, it dominates the whole page.

This must be just the preview. It looks fine on the live page and that part hasn't changed (RTX also looks too big on the preview)

It's not the preview, I can see the same problem when I build it locally. It might be the code change that I want to revert, though.

This might also explain the broken spacing of the founding/service provider lines, although I suspect that in this case it is the fault for the trusted computing logo being too large -- the bylines need to be aligned underneath the logos, which means if one of the logos sticks out, all of the bylines need to increase spacing.

As members sign the new agreements, they can pick again whether they allow the use of their logo. In the case of TUM, we were told that the university has become more restrictive, hence no logo.

As an alumni of TUM, let me just say 🙄. It's fine to have the logo on the age old coffee cup in a public cupboard, but it is not fine to have it on the website of the org they just joined. Looks like stupid in admin is winning globally. For these cases, we should still make a logo file with text, though. Trying to render text in the browser predictably is a road to madness and failure.

Signed-off-by: b@brck.nl <b@brck.nl>
Signed-off-by: b@brck.nl <b@brck.nl>
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

Preview your changes here

@bbrcknl
Copy link
Collaborator Author

bbrcknl commented Jan 8, 2026

SVGs for text logos created. NB All text logos need to be created using the same parameters, otherwise font sizes will be different post rendering. Instructions are in the readme.

@gernotheiser
Copy link
Member

bylines need to be aligned underneath the logos, which means if one of the logos sticks out, all of the bylines need to increase spacing

of course, we could bottom-align the logos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants