ci: run style check with expected Rust toolchain #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivan-Velickovic
force-pushed
the
ci_style_fix
branch
4 times, most recently
from
bd052e1 to
dabdced
Compare
The current way these style checks work means that they are based on the GitHub provided Rust toolchain rather than the one we expect. This would be fine except the rules (mainly for Clippy) seems to change every couple of weeks which is kind of annoying. Since it changes so often it means that CI fails on PRs on unrelated bits of code. Change the CI to use the Nix flake instead like we do when we build the SDK itself. Signed-off-by: Ivan Velickovic <i.velickovic@unsw.edu.au>
Signed-off-by: Ivan Velickovic <i.velickovic@unsw.edu.au>
Ivan-Velickovic
force-pushed
the
ci_style_fix
branch
from
dabdced to
e13846a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current way these style checks work means that they are based on the GitHub provided Rust toolchain rather than the one we expect.
This would be fine except the rules (mainly for Clippy) seems to change every couple of weeks which is kind of annoying.
Since it changes so often it means that CI fails on PRs on unrelated bits of code.
Change the CI to use the Nix flake instead like we do when we build the SDK itself.