use mlton from Isabelle distribution #895
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes dependency on separate mlton install. This will only work on ARM platforms from Isabelle2025 on, because the mlton version included before that is too old. Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
Now uses mlton version shipped with Isabelle Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
Xaphiosis
approved these changes
May 5, 2025
Member
Xaphiosis
left a comment
Xaphiosis
left a comment
There was a problem hiding this comment.
Where is $MLTON defined? Does it really work for standalone parser?
lsf37
commented
May 6, 2025
Comment on lines
+20
to
+22
| ifndef MLTON | ||
| MLTON := $(shell $(GLOB_PFX)/../../isabelle/bin/isabelle getenv -b ISABELLE_MLTON) | ||
| endif |
Member
Author
There was a problem hiding this comment.
This is where the definition of $MLTON happens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify installation and use the
mltonincluded in the Isabelle distribution.Needs to be merged after Isabelle2025 (#882), because before that the included
mltonis too old to support Arm platforms.