Skip to content

Conversation

@runxiyu
Copy link
Contributor

@runxiyu runxiyu commented Dec 14, 2025

I'm assuming saying rv64 there is wrong, correct me if i turn out to be wrong here

Signed-off-by: Runxi Yu <me@runxiyu.org>
Copilot AI review requested due to automatic review settings December 14, 2025 04:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an incorrect architecture description in the X64 verified configurations section of the seL4 documentation. The text was incorrectly copied from the RISCV64 section above and stated "RISC-V 64-bit architecture" when it should reference x86-64.

Key Changes

  • Corrected the architecture description for X64 configurations from "RISC-V 64-bit architecture" to "x86-64 architecture"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Indanz
Copy link
Contributor

Indanz commented Dec 14, 2025

"copilot AI review requested due to automatic review settings"

I don't think we want that, how do we turn that off?

Copy link
Member

@lsf37 lsf37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, yes indeed.

@lsf37 lsf37 merged commit 8277ded into seL4:master Dec 14, 2025
15 checks passed
@lsf37
Copy link
Member

lsf37 commented Dec 14, 2025

"copilot AI review requested due to automatic review settings"

I don't think we want that, how do we turn that off?

I've found a "default rules set for PR reviews", which I can delete, but I want to first figure out how it got there in the first place. If I have to switch this off manually for every repo, I think I'm about ready to leave GitHub.

@lsf37
Copy link
Member

lsf37 commented Dec 14, 2025

(I've tried blocking the Copilot account from the org, but the result page goes to 404..)

@lsf37
Copy link
Member

lsf37 commented Dec 14, 2025

This is richly bizarre: the audit log for this rule set claims I created it when I looked at it -- but I most certainly did not create it, and the creation event was after the PR post. So I don't know where this is coming from.

I'm not seeing the rule set in other repos.

@runxiyu runxiyu deleted the patch-1 branch December 15, 2025 02:11
@Indanz
Copy link
Contributor

Indanz commented Dec 15, 2025

This is richly bizarre: the audit log for this rule set claims I created it when I looked at it -- but I most certainly did not create it, and the creation event was after the PR post. So I don't know where this is coming from.

Te interface is quite weird, if you click on the add ruleset button, it immediately creates a default one, it's not clear that you just created it. It also doesn't ask for confirmation, it's just there.

I'm not seeing the rule set in other repos.

I hope this might be because @runxiyu asked for this in their repo or something.

If I have to switch this off manually for every repo, I think I'm about ready to leave GitHub.

Agreed.

@runxiyu
Copy link
Contributor Author

runxiyu commented Dec 29, 2025

I hope this might be because @runxiyu asked for this in their repo or something.

I don't think I enabled something like that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants