-
Notifications
You must be signed in to change notification settings - Fork 59
Fix arch description for X64 #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Runxi Yu <me@runxiyu.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes an incorrect architecture description in the X64 verified configurations section of the seL4 documentation. The text was incorrectly copied from the RISCV64 section above and stated "RISC-V 64-bit architecture" when it should reference x86-64.
Key Changes
- Corrected the architecture description for X64 configurations from "RISC-V 64-bit architecture" to "x86-64 architecture"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
"copilot AI review requested due to automatic review settings" I don't think we want that, how do we turn that off? |
lsf37
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, yes indeed.
I've found a "default rules set for PR reviews", which I can delete, but I want to first figure out how it got there in the first place. If I have to switch this off manually for every repo, I think I'm about ready to leave GitHub. |
|
(I've tried blocking the Copilot account from the org, but the result page goes to 404..) |
|
This is richly bizarre: the audit log for this rule set claims I created it when I looked at it -- but I most certainly did not create it, and the creation event was after the PR post. So I don't know where this is coming from. I'm not seeing the rule set in other repos. |
Te interface is quite weird, if you click on the add ruleset button, it immediately creates a default one, it's not clear that you just created it. It also doesn't ask for confirmation, it's just there.
I hope this might be because @runxiyu asked for this in their repo or something.
Agreed. |
I don't think I enabled something like that... |
I'm assuming saying rv64 there is wrong, correct me if i turn out to be wrong here