arm64: dts: qcom: common dtsi for Xiaomi SDM660-family (upstream prep) #166

M0Rf30 · 2026-01-14T21:00:11Z

Per discussion in #161 and #165, this prepares the common dtsi for upstream submission.

Based on torvalds/master (mainline).

Patchset:

Create sdm660-xiaomi-common.dtsi, refactor lavender to use it
dt-bindings for tulip, whyred, jasmine, platina
Add tulip DTS (Redmi Note 6 Pro)
Add whyred DTS (Redmi Note 5 Pro)
Add jasmine DTS (Mi A2)
Add platina DTS (Mi 8 Lite)

Validation:

checkpatch.pl --strict: 0 errors
make CHECK_DTBS=y: passed
All DTBs build

Please review before I send to linux-arm-msm@vger.kernel.org.

setotau · 2026-01-14T21:06:45Z

there are over 10000 commits, how can we review these changes?

setotau · 2026-01-14T21:08:25Z

there are over 10000 commits, how can we review these changes?

nvm, there are last commits I see

okias · 2026-01-14T21:24:04Z

I'll drop some nitpicks:

chosen > framebuffer - use

memory-region = <&framebufer_mem>;

instead of reg =

Except this small improvements, looks pretty good.

arch/arm64/boot/dts/qcom/sdm660-xiaomi-common.dtsi

arch/arm64/boot/dts/qcom/sdm660-xiaomi-jasmine.dts

arch/arm64/boot/dts/qcom/sdm660-xiaomi-common.dtsi

setotau

lgtm

okias

LGTM, last nitpick:
arm64: dts: qcom: add sdm660-xiaomi-common.dtsi for Xiaomi SDM660-family devices

should more like rather than "add" say something like "extract common parts into xiaomi-common". you can omit .dtsi in the commit msg

arch/arm64/boot/dts/qcom/sdm660-xiaomi-common.dtsi

arch/arm64/boot/dts/qcom/sdm660-xiaomi-jasmine.dts

arch/arm64/boot/dts/qcom/sdm636-xiaomi-tulip.dts

arch/arm64/boot/dts/qcom/sdm660-xiaomi-common.dtsi

minlexx · 2026-01-15T13:55:38Z

And I think SoB chain is wrong in most commit messages where several authors are involved (missing co-developed-by?)

At least commit messages for whyred and platina

arch/arm64/boot/dts/qcom/sdm660-xiaomi-common.dtsi

…omi-common Create a shared device tree include file for Xiaomi smartphones and tablets based on Qualcomm SDM636/SDM660 SoCs. This reduces code duplication when adding new Xiaomi devices and ensures consistent configuration across the family. The common dtsi includes: - PM660/PM660L PMIC configuration - Serial console (blsp1_uart2) - Volume and power buttons (gpio-keys, pon_pwrkey, pon_resin) - USB (qusb2phy0, usb3) in peripheral mode - SD card (sdhc_2) with card detect on GPIO 54 - eMMC (sdhc_1) with HS400 support - Backlight (pm660l_wled) - Framebuffer memory reservation - TLMM GPIO reserved ranges Refactor sdm660-xiaomi-lavender.dts to include the common file while keeping device-specific parts (ramoops, regulators) in the board DTS. Signed-off-by: Gianluca Boiano <morf3089@gmail.com>

Add device tree bindings for: - Xiaomi Redmi Note 6 Pro (tulip) - SDM636 - Xiaomi Redmi Note 5 Pro (whyred) - SDM636 - Xiaomi Mi A2 (jasmine) - SDM660 - Xiaomi Mi 8 Lite (platina) - SDM660 These are Android-based smartphones that can boot mainline Linux with simple-framebuffer and USB support. Signed-off-by: Gianluca Boiano <morf3089@gmail.com>

Add initial device tree support for the Xiaomi Redmi Note 6 Pro (codename: tulip), a smartphone based on Qualcomm SDM636 SoC with 4GB RAM and a 6.26" 1080x2280 display. This enables booting to a framebuffer console with USB support for debugging. Signed-off-by: Gianluca Boiano <morf3089@gmail.com>

Add initial device tree support for the Xiaomi Redmi Note 5 Pro (codename: whyred), a smartphone based on Qualcomm SDM636 SoC with 4/6GB RAM and a 5.99" 1080x2160 display. This enables booting to a framebuffer console with USB support for debugging. Co-developed-by: Alexey Minnekhanov <alexeymin@postmarketos.org> Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org> Signed-off-by: Mathesh Velayudan <123v.mathesh@gmail.com> Signed-off-by: Gianluca Boiano <morf3089@gmail.com>

Add initial device tree support for the Xiaomi Mi A2 (codename: jasmine), a smartphone based on Qualcomm SDM660 SoC with 4/6GB RAM and a 5.99" 1080x2160 display. This enables booting to a framebuffer console with USB support for debugging. Signed-off-by: Joe Mason <buddyjojo06@outlook.com> Signed-off-by: Gianluca Boiano <morf3089@gmail.com>

Add initial device tree support for the Xiaomi Mi 8 Lite (codename: platina), a smartphone based on Qualcomm SDM660 SoC with 4/6GB RAM and a 6.26" 1080x2280 display. This enables booting to a framebuffer console with USB support for debugging. Co-developed-by: Molly Sophia <mollysophia379@gmail.com> Signed-off-by: Molly Sophia <mollysophia379@gmail.com> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> Signed-off-by: Gianluca Boiano <morf3089@gmail.com>

okias · 2026-01-15T14:57:39Z

arch/arm64/boot/dts/qcom/sdm660-xiaomi-common.dtsi

+			 * by individual device dts
+			 */
+			format = "a8r8g8b8";
+			status = "disabled";


newline before status

okias · 2026-01-15T15:01:25Z

arch/arm64/boot/dts/qcom/sdm660-xiaomi-platina.dts

+};
+
+&tlmm {
+	gpio-reserved-ranges = <8 4>;


while we at it, mainline developers wants these days inline comment, what these GPIOs are reserved to.

Sample of recently merged Pixel 3 DT:

gpio-reserved-ranges = < 0 4>, /* SPI (Intel MNH Pixel Visual Core) */ <81 4>; /* SPI (most likely Fingerprint Cards FPC1075) */

So for platina GPIOs 8..11 are for fingerprint SPI.

~~And looks like GPIOs 0..3 should also be reserved for eSE (embedded Secure Element) ? But we can't test platina, so..~~ or maybe not, it's the same for lavender and it boots fine without reserving 0..3.

Is this secure element related to NFC? Afaik platina doesn't have it.

For whyred, jasmine and lavender it's the same - gpios 8..11 are "Fingerprint SPI"

Is this secure element related to NFC? Afaik platina doesn't have it.

Perhaps

I've googled. It doesn't relate to NFC.

minlexx · 2026-01-15T20:01:28Z

And I think SoB chain is wrong in most commit messages where several authors are involved (missing co-developed-by?)

At least commit messages for whyred and platina

I think in commit messages SoB chain should go top-to-bottom in chronological order: https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

So, for whyred:

Co-developed-by: Mathesh Velayudan <123v.mathesh@gmail.com>
Signed-off-by: Mathesh Velayudan <123v.mathesh@gmail.com>
Co-developed-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
Signed-off-by: Alexey Minnekhanov <alexeymin@postmarketos.org>
Signed-off-by: Gianluca Boiano <morf3089@gmail.com>

for platina also Angelo was the original author, so:

Co-developed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Co-developed-by: Molly Sophia <mollysophia379@gmail.com>
Signed-off-by: Molly Sophia <mollysophia379@gmail.com>
Signed-off-by: Gianluca Boiano <morf3089@gmail.com>

minlexx · 2026-01-15T20:16:42Z

Also your every device's commit message says "..USB support for debugging." but it's a normal USB, not just for debugging? 😺

M0Rf30 changed the base branch from qcom-sdm660-6.18.y to master January 14, 2026 21:15

okias suggested changes Jan 14, 2026

View reviewed changes

arch/arm64/boot/dts/qcom/sdm660-xiaomi-common.dtsi Outdated Show resolved Hide resolved

setotau reviewed Jan 14, 2026

View reviewed changes

arch/arm64/boot/dts/qcom/sdm660-xiaomi-jasmine.dts Show resolved Hide resolved

M0Rf30 force-pushed the upstreaming/xiaomi-common-v1 branch 2 times, most recently from d1d4031 to 94987e4 Compare January 14, 2026 21:47

setotau reviewed Jan 14, 2026

View reviewed changes

arch/arm64/boot/dts/qcom/sdm660-xiaomi-common.dtsi Outdated Show resolved Hide resolved

M0Rf30 force-pushed the upstreaming/xiaomi-common-v1 branch 2 times, most recently from b2134b9 to 0c3ae74 Compare January 14, 2026 22:25

M0Rf30 requested review from minlexx, okias and setotau January 15, 2026 13:08

setotau approved these changes Jan 15, 2026

View reviewed changes

okias suggested changes Jan 15, 2026

View reviewed changes

M0Rf30 force-pushed the upstreaming/xiaomi-common-v1 branch from 0c3ae74 to fdc6544 Compare January 15, 2026 13:53

minlexx requested changes Jan 15, 2026

View reviewed changes

M0Rf30 force-pushed the upstreaming/xiaomi-common-v1 branch from fdc6544 to feaec76 Compare January 15, 2026 14:06

minlexx reviewed Jan 15, 2026

View reviewed changes

arch/arm64/boot/dts/qcom/sdm660-xiaomi-common.dtsi Outdated Show resolved Hide resolved

M0Rf30 force-pushed the upstreaming/xiaomi-common-v1 branch from feaec76 to 3beb0a2 Compare January 15, 2026 14:15

M0Rf30 added 6 commits January 15, 2026 15:21

M0Rf30 force-pushed the upstreaming/xiaomi-common-v1 branch from 3beb0a2 to 0910450 Compare January 15, 2026 14:24

M0Rf30 requested a review from minlexx January 15, 2026 14:26

M0Rf30 requested a review from okias January 15, 2026 14:32

okias reviewed Jan 15, 2026

View reviewed changes

arm64: dts: qcom: common dtsi for Xiaomi SDM660-family (upstream prep) #166

Are you sure you want to change the base?

arm64: dts: qcom: common dtsi for Xiaomi SDM660-family (upstream prep) #166

Uh oh!

Conversation

M0Rf30 commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

setotau commented Jan 14, 2026

Uh oh!

setotau commented Jan 14, 2026

Uh oh!

okias commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

setotau left a comment

Choose a reason for hiding this comment

Uh oh!

okias left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

minlexx commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

okias Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

okias Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

minlexx Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

setotau Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

minlexx Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

minlexx Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

setotau Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

minlexx commented Jan 15, 2026

Uh oh!

minlexx commented Jan 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

M0Rf30 commented Jan 14, 2026 •

edited

Loading

okias commented Jan 14, 2026 •

edited

Loading

okias left a comment •

edited

Loading

minlexx commented Jan 15, 2026 •

edited

Loading

minlexx Jan 15, 2026 •

edited

Loading