ci: consolidate workflows and add pyright type checking #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Consolidate pylint, yapf, and ruff into a single 'lint' job - Combine mypy into 'type-check' job and add pyright alongside it - Fix exit code masking by adding 'set -o pipefail' in integration tests - Add workflow_call trigger to main.yml for reuse - Simplify release.yml by calling main.yml instead of duplicating jobs - Update codecov-action to v5
The kdumpling dependency is installed via pip install . which was missing from the lint, type-check, pytest-unit, and pytest-integration jobs in the consolidated workflow.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #26 +/- ##
============================================
- Coverage 76.13% 38.37% -37.77%
============================================
Files 69 69
Lines 4036 4050 +14
Branches 625 626 +1
============================================
- Hits 3073 1554 -1519
- Misses 809 2453 +1644
+ Partials 154 43 -111 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Remove redundant 'install' job from CI (all other jobs now install sdb) - Export 'error' and 'target' submodules in sdb/__init__.py for proper module access (fixes pyright errors like sdb.target.create_object()) - Add pyright configuration to pyproject.toml with appropriate settings for drgn interoperability - Fix pyright errors: - Add None checks before iterating over .members and .enumerators - Fix return type annotations on generator functions (spa.py, zio.py) - Fix variable shadowing bug in metaslab.py (vdev -> vdev_id) - Use assert statements for guaranteed non-None after if checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pylint,yapf, andruffinto a singlelintjob (reduces CI time by avoiding repeated setup)mypyintotype-checkjob and addpyrightalongside it for more comprehensive type checkingset -o pipefailin integration tests (ensures pytest failures are properly reported when piping output)workflow_calltrigger to main.yml for reuse by other workflowsTest plan