Skip to content

remove the unused mutex from sharedEntryAttributes #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steiler merged 1 commit into from
Feb 16, 2026
+0 −12
Merged

remove the unused mutex from sharedEntryAttributes #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions pkg/tree/root_entry_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ func TestRootEntry_TreeExport(t *testing.T) {
parent: nil,
pathElemName: "",
childs: newChildMap(),
childsMutex: sync.RWMutex{},
schemaMutex: sync.RWMutex{},
cacheMutex: sync.Mutex{},
treeContext: tc,
Expand Down Expand Up @@ -95,7 +94,6 @@ func TestRootEntry_TreeExport(t *testing.T) {
parent: nil,
pathElemName: "",
childs: newChildMap(),
childsMutex: sync.RWMutex{},
schemaMutex: sync.RWMutex{},
cacheMutex: sync.Mutex{},
treeContext: tc,
Expand All @@ -107,7 +105,6 @@ func TestRootEntry_TreeExport(t *testing.T) {
parent: result,
pathElemName: "interface",
childs: newChildMap(),
childsMutex: sync.RWMutex{},
schemaMutex: sync.RWMutex{},
cacheMutex: sync.Mutex{},
}
Expand Down Expand Up @@ -162,7 +159,6 @@ func TestRootEntry_TreeExport(t *testing.T) {
parent: nil,
pathElemName: "",
childs: newChildMap(),
childsMutex: sync.RWMutex{},
schemaMutex: sync.RWMutex{},
cacheMutex: sync.Mutex{},
treeContext: tc,
Expand All @@ -174,7 +170,6 @@ func TestRootEntry_TreeExport(t *testing.T) {
parent: result,
pathElemName: "interface",
childs: newChildMap(),
childsMutex: sync.RWMutex{},
schemaMutex: sync.RWMutex{},
cacheMutex: sync.Mutex{},
}
Expand Down Expand Up @@ -208,7 +203,6 @@ func TestRootEntry_TreeExport(t *testing.T) {
parent: result,
pathElemName: "system",
childs: newChildMap(),
childsMutex: sync.RWMutex{},
schemaMutex: sync.RWMutex{},
cacheMutex: sync.Mutex{},
}
Expand Down Expand Up @@ -263,7 +257,6 @@ func TestRootEntry_TreeExport(t *testing.T) {
parent: nil,
pathElemName: "",
childs: newChildMap(),
childsMutex: sync.RWMutex{},
schemaMutex: sync.RWMutex{},
cacheMutex: sync.Mutex{},
treeContext: tc,
Expand All @@ -275,7 +268,6 @@ func TestRootEntry_TreeExport(t *testing.T) {
parent: result,
pathElemName: "interface",
childs: newChildMap(),
childsMutex: sync.RWMutex{},
schemaMutex: sync.RWMutex{},
cacheMutex: sync.Mutex{},
}
Expand Down
2 changes: 0 additions & 2 deletions pkg/tree/sharedEntryAttributes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ type sharedEntryAttributes struct {
pathElemName string
// childs mutual exclusive with LeafVariants
childs *childMap
childsMutex sync.RWMutex
// leafVariants mutual exclusive with Childs
// If Entry is a leaf it can hold multiple leafVariants
leafVariants *LeafVariants
Expand Down Expand Up @@ -63,7 +62,6 @@ func (s *sharedEntryAttributes) deepCopy(tc *TreeContext, parent Entry) (*shared
schema: s.schema,
treeContext: tc,
choicesResolvers: s.choicesResolvers.deepCopy(),
childsMutex: sync.RWMutex{},
schemaMutex: sync.RWMutex{},
cacheMutex: sync.Mutex{},
level: s.level,
Expand Down
2 changes: 0 additions & 2 deletions pkg/tree/sharedEntryAttributes_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import (
"runtime"
"slices"
"strings"
"sync"
"testing"

"github.com/google/go-cmp/cmp"
Expand Down Expand Up @@ -99,7 +98,6 @@ func Test_sharedEntryAttributes_DeepCopy(t *testing.T) {
sharedEntryAttributes: &sharedEntryAttributes{
pathElemName: "__root__",
childs: newChildMap(),
childsMutex: sync.RWMutex{},
choicesResolvers: choiceResolvers{},
parent: nil,
treeContext: tc,
Expand Down